How make my code better?

How make my code better?
0.0 0

#1

Tell us what’s happening:
Thats my working solution for this task.
But I think it should look better.
Have u any advice for do will my code better?
Thx!

Your code so far

//Setup
var contacts = [
    {
        "firstName": "Akira",
        "lastName": "Laine",
        "number": "0543236543",
        "likes": ["Pizza", "Coding", "Brownie Points"]
    },
    {
        "firstName": "Harry",
        "lastName": "Potter",
        "number": "0994372684",
        "likes": ["Hogwarts", "Magic", "Hagrid"]
    },
    {
        "firstName": "Sherlock",
        "lastName": "Holmes",
        "number": "0487345643",
        "likes": ["Intriguing Cases", "Violin"]
    },
    {
        "firstName": "Kristian",
        "lastName": "Vos",
        "number": "unknown",
        "likes": ["Javascript", "Gaming", "Foxes"]
    }
];


function lookUpProfile(firstName, prop){
// Only change code below this line
       var answer = {};
    for (var index = 0; index < contacts.length; index++) {
        var element = contacts[index];
        if (element.firstName === firstName) {
            if (element.hasOwnProperty(prop)) {
                answer = element[prop];
            } else {
                answer = "No such property";
            }
        }
    }
    if(Object.keys(answer).length === 0) {
        answer = "No such contact";
    }
    return answer;
  
// Only change code above this line
}

// Change these values to test your function
lookUpProfile("Akira", "likes");

Your browser information:

Your Browser User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36.

Link to the challenge:


#2

You have a double tab indent here. A single tab indent would look much better.
Seriously, if the code works, well done. Move on to the next challenge.


#3

Yep, but here I used Object.keys(answer).length. That not a part of previous challenges. I think must be a way for complete current challenge only with previous info.


#4

It’s up to you. You can spend time working on this challenge until you are happy with it or you can move on.
Some users prefer to revise by returning to challenges and doing them all again with the new knowledge they have gained.