https://hiteshrohira.github.io/SpaceX/

Code Feedback
1

https://hiteshrohira.github.io/SpaceX/

Here’s my tribute to SpaceX.

Please provide your Feedback

1 Like
2

looks great
thought you can remove the FCC test link

1 Like
3

Hello~!

This is incorrect - for the projects that use the test suite, your project must be submitted with the test script present and all tests must be passing. :slight_smile:

4

hey @nhcarrigan he has uploaded project on github and there is no need of it after the project is complete
just blocking the eyesight .

5

@nhcarrigan are you saying that to @Advitya-sharma or me??

Coz I have applied the test script and all the tests are passing

1 Like
6

you just need to close the x mark

7

If the link he submitted isn’t the github link, it’s okay to remove the script. But generally you want to keep the test script on the project you submit, especially if you ask for feedback. :slight_smile:

8

Page looks okay @HiteshRohira. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are HTML coding errors you should address.
  • Don’t use <br> to force line breaks or spacing. That’s what CSS is for.
    • If you want three paragraphs then have three paragraph elements. If you want a list, then make a list.
  • Review the lesson about giving meaningful text to links.

Regarding the test script;
The test script should be included, with all tests passing, when you submit your projects.
It doesn’t matter if you submit the project via codepen, GitHub page, repl.it, jsfiddle…the test script should be there. So you did the right thing by leaving it on your page.