I face two testing issue on my final project

I face two testing issues on my final project even if I code(set) the required, info?
here are my two issues.
first, he asks me to set the height of the welcome section to be the height of the viewport and I set. like these on my CSS.
#welcome-section{
height: 100vh;
background-color:#ee;
overflow: auto;
border: 1px solid green;
}

  • second he ask me to set a link with id of profile-link and when click it opens
    github page on the new tab and i set like these
  • myProfile
  • inside nav. but i still get Thesee two issue. here is my code. https://codepen.io/solomon123fgt/pen/rNVGGbB

    (Edited since I noticed I’m mistaken).

    Your profile link does not open in a new tab. I asssume that’s the reason for the error.

    i set target=“_blank” in my link it opens in a new tab but it still does not pass the test

    1 Like

    i set my welcome section’s height to be the height of viewport like these
    #welcome-section{
    height: 100vh;
    background-color:#ee;
    overflow: auto;
    border: 1px solid green;
    }
    but it does not work. i try even by delating medai-query. i does not work
    code; https://codepen.io/solomon123fgt/pen/rNVGGbB

    the tests say there is nothing with id="profile-link"

    also, you have set the welcome section to 100vh, but the border makes it higher than that
    so or you substract the border from the viewport height (I recently found the calc() function in css, you may research that), or you remove the border

    Yes you solve all my broblem. i remove border and i set id=“profile-link” and the issue is solved. Thank you