I hv summitted this project but its not marked as completed

above link is my project.

Challenge: Build a Product Landing Page

Link to the challenge:

1 Like

here’s the link to my first ever coding project. Please review it and guide me to improve in upcoming projects . Thank you

Nice work! Here’s some of my recommendations.

  • Make sure you are taking a mobile first approach. First use your web browser’s dev tools to make your site look good on smaller screen sizes. Then use media queries to adjust your design for larger screen sizes.

  • Get rid of the white space that’s around the outside of your body element. You can start by setting your body margin to zero. You have other css to change besides your body margin to achieve this.

  • Consider using a centered text approach. It’s a more pleasant experience to have centered text on a web page.

  • Use border-bottom instead of the default text underlining. Border-bottom can be customized to not break from low-hanging letters like “p” by making the border-bottom below letters like “p”.

1 Like

Your page looks good @arun0072mj. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
      (The one for HTML misses things which is why I recommend W3C)
  • There is a shorter way to write this margin: 10px auto 10px auto;
    Do you remember? What does research show you?
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    • Reference MDN Docs
      If you want multiple paragraphs then create multiple paragraph elements.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • click here to know more” is not accessible
1 Like