I just finished my first project(Tribute Page) with FCC

I just finished my first project(Tribute Page) with FCC
0.0 0

#1

This is my first project. I would appreciate any feedback, or advice. I will work harder and study more. Thank you so much :slightly_smiling_face:


#2

Maybe consider adding a margin on the left and right of the list?

Also, why are you using JavaScript to set the font-size for the h1 element? Why not just use CSS? You already know how to change the font size of the h2 element. Just do something similar for the h1 element.

And why did you stick the following in the middle of your html? You can not change the size of the h1 element the way you are trying to do here. See my comment above for changing the font size.

  <style>
    .smaller-image {
    width: 100px;
    }
    h1 {size}
  </style>

Lastly, you are using li elements, but you did not nested them in a ul element. Instead you attempted to nest them in a p element.


#3

Your image doesnโ€™t scale when scaling down.
Maybe you could use something like img-fluid in your img element?