I just finished this project and i could really use some tips or criticism on it. let me know what you guys think

https://codepen.io/staranbeer/full/bGrQpWY

Your page looks good @staranbeer. Some things to revisit;

  • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 15/16 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
      Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance, links to fonts go in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
      Since copy/paste from codepen you can ignore the first warning and first two errors.
  • The “navigation menu” link never gets focus when the user tabs through.
  • When tabbing through the nav list has an indication of where the user is. When using the cursor that indication is not there.
    It would be a better UX if hover and focus looked the same.

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.