I need help with a C++ code again

1

So i wrote a code, and i need it to return codes that have been put in. But it returns 0. help please （´＿｀）
here is the code:

#include <iostream>
using namespace std;

int scores(int score1, int score2, int score3){
      int best_score;
      if (score1 > score2 && score1> score3){
        score1 = best_score;
      } else if(score2 > score1 && score2 > score3){
        score2 = best_score;
      } else if(score3> score1 && score3 > score2){
        score3 = best_score;
      }

}

int main()
{
    int best_score;
    int score1;
    int score2;
    int score3;
    cout<< "player 1, enter your score: ";
    cin>> score1;
    cout<< "player 2, enter your score: ";
    cin>> score2;
    cout<< "player 3, enter your score: ";
    cin>>score3;
    best_score = scores(score1,score2,score3);
    cout<< "The highest score is "<< best_score;
    return 0;


}
2

I don’t see a return statement for this function.

3 
#include <iostream>
using namespace std;

int scores(int score1, int score2, int score3){
      int best_score;
      if (score1 > score2 && score1> score3){
        score1 = best_score;
      } else if(score2 > score1 && score2 > score3){
        score2 = best_score;
      } else if(score3> score1 && score3 > score2){
        score3 = best_score;
      }
      return 0;

}

int main()
{
    int best_score;
    int score1;
    int score2;
    int score3;
    cout<< "player 1, enter your score: ";
    cin>> score1;
    cout<< "player 2, enter your score: ";
    cin>> score2;
    cout<< "player 3, enter your score: ";
    cin>>score3;
    best_score = scores(score1,score2,score3);
    cout<< "The highest score is "<< best_score;
    return 0;


}

thanks, i thought i didnt needed it. But it still returns zero. Do you see any other mistakes maybe?

4

Now you are always returning zero instead of the best score

Also, I suspect you want best_score on the left side of the =

Order matters with =

5

Thanks, it worked.
banzai

1 Like