Hi All,
I created this tribute page to highlight the life and work of Ruth Bader Ginsburg. The page includes interactive audio quotes. Your feedback on usability of the page and layout suggestions would be of great help. Thank you!
Hi All,
I created this tribute page to highlight the life and work of Ruth Bader Ginsburg. The page includes interactive audio quotes. Your feedback on usability of the page and layout suggestions would be of great help. Thank you!
Hey, this looks very nice. You arenāt passing one test though.
A few suggestions:
<a ...>Read more <span class='visually-hidden'>about Califano v. Goldfarb (1976)</span></a>
Google ācss visually hiddenā to get the CSS for the visually-hidden class.
All of those black, bold case titles should be headings.
The quotes can be marked up with <blockquote>
. You can go even further and use that in combination with a <figure>
and <figcaption>
for the speaker: <blockquote>: The Block Quotation element - HTML: HyperText Markup Language | MDN
Iām not sure Iām crazy about the quote being clickable for stopping/starting the sound clip. I think most people assume that underlined text is a link that will take them to another page. Sure, they will figure it out rather quickly. Iām not saying donāt do this. But always be extra cautious when going against SOP.
This is definitely a more advanced issue, but the default audio controls for the <audio>
element are generally not accessible. MDN gives a good overview of the problems. I donāt think anyone expects you to deal with this for this project. I just wanted to make you aware of it.
Overall, this is a very nice job. Everything is responsive and I think the page layout and content is put together extremely well. Good job!
Welcome back @jacobmwhitney1. Page looks good. Some things to revisit;
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
)
I just want to say thank you for your detailed feedback. After reviewing your notes and resources, I was able to make all the changes you suggested, except the audio controls. And I have included these steps into my regular workflow now. The MDN link about accessible audio controls was helpful as well and when I have the time, I will be going back to attempt those adjustments. Thank you again, cheers!
Thank you for heads up. The page is now passing 10/10 user stories and all errors have been removed. This process helped me a ton!
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.