Jeff Foxworthy Tribute Page

Jeff Foxworthy Tribute Page
0

#1

Okay, after a LOT of digging through the documentation (HTML5, Bootstrap, and CSS), I think my tribute page is ready for public viewing. This isn’t my first ever page, but it is probably my best so far, I think.

Please go to my page, and then leave me some feedback! Is there anything that I loused up on? Please let me know.

Thanks!

James


#2

Hi

This looks like a list:

<div class="col-xs-1 col-sm-offset-2">
      <p><strong>1990</strong></p>
    </div>
    <div class="col-xs-9 col-sm-6">
      <p>Awarded Funniest Male Stand-up Comic at American Comedy Awards</p>
    </div>
  </div>
  <br/>
<div class="row">
    <div class="col-xs-1 col-sm-offset-2">
      <p><strong>1993</strong></p>
    </div>
    <div class="col-xs-9 col-sm-6">
      <p>First used the comedy line "...You Might Be A Redneck If..."</p>
    </div>
  </div>
  <br/>

MDN documentation:

This code is not correct ( br tag):

<div class="row">
    <div class="col-xs-1 col-sm-offset-2">
      <p><strong>2015</strong></p>
    </div>
    <div class="col-xs-9 col-sm-6">
      <p>Jeff and Larry the Cable Guy launch 24/7 SiriusXM Comedy Channel</p>
    </div>
  </div>
  <br/>  <-- here
  <br/>  <-- here
  <div>

MDN documentation:

The HTML element line break <br> produces a line break in text (carriage-return). It is useful for writing a poem or an address, where the division of lines is significant.
Do not use <br> to increase the gap between lines of text; use the CSS margin property or the p> element.

Cheers and happy coding :slight_smile:


#3

Thanks for the critique. The line breaks are gone, and I went with Bootstrap’s

(Description list), since it seems to suit the purpose well. (Year, what happened, repeat), and it really cleaned up the code.

I also went through and compared opening and closing of the div statements, and discovered I had missed closing one somewhere along the way. That’s taken care of, and a couple of other, cosmetic changes.

Is there anything else I need to think about on this assignment, or should I call it good?

James


#4

You’re welcome. I think is good :thumbsup: .

Cheers and happy coding :slight_smile: