Joe's Portfolio

Code Feedback
1

I know it’s nothing special, but I would love some feedback. I’m pretty confident in the actual function, but I’m awful with design. So any recommendations would be much appreciated!

Update:
I didn’t realize that I didn’t provide a link until too late. Then I got really busy for a few days and haven’t had the time to come back here. So here is the link to my current profile page:
https://deedle42.github.io/portfolio/

1 Like
2

I’m assuming this is the link to the portfolio, account has same username and name:

https://codepen.io/deedle42/pen/PLbdzB

3

If you want to post links, bookmark the message you got from @discobot and go through the tutorial.

4

Hi! To find out what I can do, say @discobot display help.

1 Like
5

So, my feedback:
It looks nice, other than the broken images. To fix them, go to imgur.com, new post, upload the image, then right-click on the image and copy the link location. Then, you can paste them into your img src.

6

It looks good @deedle42, just a couple of things;

  • codepen provides you with validators for HTML, CSS and JS. Click on the arrow in the upper right and then click on the respective ‘Analyze’ link. You have some issues in HTML that you can easily clean up.
  • when a user clicks on a link to your project it should open in a new page, target="_blank", remember?

Edit:
imgur is not a good site to host your images…it doesn’t play well with FCC. I use GitHub for hosting my images. If you’re not familiar with that, just do a quick search here, there are others who have found good sites to use for image hosting.

7

I know, it’s just a quick & dirty approach.

8

Also, consider going to pen settings, html, insert the most common viewport meta tag, then save & close. By doing this, it will look much better on mobile.