Hello! Any feedback on design or code is much appreciated. (Also, I’m new here and just posted this and survey project hopefully in the correct way!)
i found the design very clean, and help the reading experience.
Nice font color , and nice background .
good luck in the next chellenges
Your page looks good @taramichelle. Some things to revisit;
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
bodyelement in HTML. (No need to include the body tags). For anything you want to add to
<head>click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
- The link to your font would go in the box labeled ‘Stuff for <head>’
- Run your HTML code through the W3C validator.
- There are coding errors you need to address.
- A suggestion, it would be easier to read the tribute info if it was left justified rather than centered. The eye gets tired quickly trying to read like that.
- A suggestion, since each item in the tribute info is preceeded by a bold date, maybe when left justified get rid of the bullets
- Review the lesson about giving meaningful text to links.
- Web Accessibility in Mind has a more thorough explanation
- “learn more” is not accessible
Thank you so much for such detailed feedback. I ran my code through the W3C validator and have a question about the
<figcaption> tags. I see now that they have to be used together, not mixed with a
<div>, but the project asks us to use a
<div> for our image and caption, not
<figure>. Is this an outdated practice or is either one acceptable as long as you don’t mix the two?
Thanks again for the suggestions! I made the updates you mentioned
Thank you so much for taking a look!
It’s just one of the ways you can do it. FCC had you do it one way to conform to tests.
Your page looks really good. I like it justified and without the bullets.