Hi guys,
the very first time I developed a webpage and coded it from scratch. Therefore I am happy for any feedback.
Thx
Mirko
Hi guys,
the very first time I developed a webpage and coded it from scratch. Therefore I am happy for any feedback.
Thx
Mirko
Looks good, one thing i would change is when the screen gets smaller and the image is moved under the paragraph, you could center the image
Thanks for your feedback! Good suggestion - just done.
oh thatâs so good! lol like really.
when I did my tribute way back in the day (last week) I put everything in one âwell/cardâ but you have this page done in sections and that looks really good to me @MirkoH.
I wana offer some advice too. But before I do i wana say Iâm not bashin your page itâs fine the way it is and Iâm not completely sure bout this because Iâve been doinâ this for only as long as you have but, I think using more JS and less CSS might be better. I donât know, I feel like I heard that somewhere here.
How would we go about that @mykola2306?
Add âimage: centerâ to the Bootstrap cell?
Wouldnât Image-responsive do that automatically?
Thanks so much @Zip!
Re your suggestion: you might be absolutely right, but so far I have no knowledge about JS as it is later in the curriculum. Therewith I was limited to css and bootstrap.
Oh I think I meant jQuery.
Yea? idk.
Nyway ur welcome man, we gota support each other round here.
@MirkoH Your HTML structure is done well, as @Zip notes. Here are some ideas for improvement:
Use the proper document structure:
We must always be sure to the use proper document structure, including the
<!DOCTYPE html>
doctype, and the<html>
,<head>
, and<body>
elements. Doing so keeps our pages standards compliant and fully semantic, and helps guarantee they will be rendered as we wish.
(Source)
You can learn more about this document structure in Free Code Campâs beta curriculum (1 | 2).
You may want to implement <header>
and <footer>
sectioning elements. These are good for making code more readable:
Current:
<p class="text" id="footer"><i>Written and coded by Mirko Hannig</i></p>
Semantic:
<footer>
<p class="text">Written and coded by Mirko Hannig</p>
</footer>
You may want to add comments to your CSS. This is totally optional, but really helpful for helping others read your code.
Some developers suggest not using id selectors in your CSS. This likely isnât a big deal on your current page, but itâs something helpful to know for future reference.
You did great work here! Iâm looking forward to reviewing your future projects.
God! I swear I this forum!!!
I learned that stuff but itâs like, hearing it from someone really helps drive it home.
Hereâs a question though:
$("footer").functionHere("changeHere");
?
@Zip I think what you have will work, yes. <footer>
is the same type of native HTML element (as far as JavaScript and JQuery are concerned) as <html>
, <body>
, <p>
, <li>
, etc⌠Hereâs the relevant FCC challenge.
In that example, "button"
can be exchanged for any HTML tag, "footer"
included.
Does that sound right to you?
Thanks @camper for your detailed feedback.
I went without Doctype and html based on the instructions I got here: https://medium.freecodecamp.org/codepen-tips-and-best-practice-cf926ebd0b11 under the section âLet´s remove some thingsâ.
But indeed I have to add a body element.
Thank you much for the tip with ID selectors and footer. Was not aware of that: I will change respectively consider that in future projects.
Yea @camper. Thatâs it.
And Iâm pretty sure thatâs called semantic naming but Iâd have to go check the thread I learned that in.