Just completed Random Quote Machine. Would love some feedback

Just completed Random Quote Machine. Would love some feedback
0

#1

I have tried to keep it simple. Hopefully, it resonates with the purpose of the page. Here is the link to my pen. I would love your feedback. Thanks.


#2

Slight problem with tweeting. The author when I tweet is NaN.


#3

I have made the change so that it works in codepen.io. For some reason it works differently on codepen and my local machine. Sorry.


#4

Looks good, only one bug - can’t tweet quotes containing ; or %.
Look into encodeURIComponent().


#5

using encodeURIcomponent() in codepen.io breaks the link


#6

I just checked and it seems that you are using encodeURIcomponent() now and everything works fine.