Lading page for a vaping store

Code Feedback
1

would like to have positive (and negative if there any) insights

David

2

Hey, overall I like it. Very nice parallax effect.

I would suggest (higher to lower importance in my scale):

  1. Add some padding to the main element (I mean, the element wrapping all but footer and navbar).
  2. The items health, etc. should contain some background, probably with transparency, maybe each a different color. You want them to stand over the background a bit more.
  3. Same for the images, you can look up how boostrap styles images. also. Again here, I would add a background, probably something like this: background-color:rgba(0,0,0,0.3), and maybe change the border by a box-shadow with the same color but some spread etc.
  4. I would do something different with the navbar, maybe add little transparency too, and a bottom border

You could use the white of the smoke (with the color picker tool pick the color) for the cards background.

I would pick a somewhat different font, or maybe 2 types one for text, one for headers, but you might look into it yourself.

Other stuff

  • I found the analyze html returns some missing <div> you might want to fix that.
  • The footer copyright and links should be on the same line.
  • Very nice logo!

Again, I like it so this is just some ideas more than fixings!

3

Your page looks good @Eldorado82. Something to revisit;

  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are HTML coding errors you should be aware of and address.

When you get a little further into coding come back to this page and look at it again. Maybe add some padding so that when the user clicks a link in the navbar the top of the section isn’t hidden behind the navbar.
When you learn bootstrap in later lessons, maybe take misterybodon’s advice or create another similar page to see the difference.

4

Thanks @anon10002461 and @Roma!

Defenetly, I’m planning to revisit my projects once i get into JS, bootsrap and all of it… because as for now, my control of html/css is rather… not the smooth I want, so my plan was to return and to have a look from a new perspective after learning and practicing for a while

5