Landing page - INNO LIMB

Code Feedback
1

Hello everybody!
Made my first one-page site! I’m terribly tired of trying to figure it out, but the result is good. The site is not responsive and has not been completed a bit according to the design idea. Please evaluate and not throw stones)))

The structure of html is terrible - you don’t have to try to figure it out … I learned a lot during the project, and there was no longer any strength left to redo it. Therefore, the project has a lot of “crutches”. Well, css is not better)))

Have a nice day, everyone!

NINJA’S CODE

2

You are shooting for the “Responsive” Web Design Certificate so I think it might be a good idea to spend the extra time to make it responsive.

1 Like
3

Hi @kalyrgin !

I think the design looks cool but you are right that it is not responsive at all.

It would be shame to spend all of this time designing something and it not look good on all devices.

You should want your page to be enjoyed by everyone. :grinning:

I don’t think it is terrible. I just think there is room for improvement.

Just a couple of questions though.

Why are these divs here? Do they do something?

  <li tabindex="1">
      <div></div>
   </li>
   <li tabindex="2">
      <div></div>
   </li>

In general, you might be overusing the div. Like for here, you can just use p tags for the text.

   <div>
     <div>with love</div>
   </div>

All imgs should have alt text

<img src="https://i.postimg.cc/sfmYZFHv/Arcana.png" align="right" alt="">

For here it would be nice if you wrapped the labels around the input.

  <label for="fullname">Full Name</label>
          <input type="text" id="fullname">

I know you spent a lot of time on it but you want your pages to be enjoyed by everyone no matter the device :grinning:

1 Like
4

Thank you for your feedback!) I understand that it was necessary to make a responsive design. But by the end of the non-adaptive version, I was a little burned out to this project … I did it for a little over 40 hours. I understood a lot to do exactly as I intended. As a result, my layout differs in places from the original of my design. I did not include time for design.

Of course, I’ll make this site responsive. I need to take a break from him)))

5

Thank you very much! I am very glad that you pointed out my mistakes to me. I really used a lot of

elements, which would be more reasonable to replace with more appropriate ones. I will try to avoid this aspect in the future!))

6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.