Learn CSS Variables by Building a City Skyline - Step 116

Tell us what’s happening: On step 116 I’m getting a fail on the test stating, " You should change the first color values from #ffcf33 to #ccc ."

Your code so far: before change is

.sky {
background: radial-gradient(circle closest-corner at 15% 15%, #ffcf33 0%, #ffcf33 20%, #ffff66 21%, #bbeeff 100%);
}
after is
.sky {
background: radial-gradient(circle closest-corner at 15% 15%, #ccc 0%, #ccc 20%, #445 21%, #223 100%);
}
Can I get a hint why this code doesn’t pass?

WARNING

The challenge seed code and/or your solution exceeded the maximum length we can port over from the challenge.

You will need to take an additional step here so the code you wrote presents in an easy to read format.

Please copy/paste all the editor code showing in the challenge from where you just linked.

Replace these two sentences with your copied code.
Please leave the ``` line above and the ``` line below,
because they allow your code to properly format in the post.

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36

Challenge Information:

Learn CSS Variables by Building a City Skyline - Step 116

Please share all of your CSS, not just the specific ruleset you are working on for this step. Also, please paste your CSS in here using the following method.

To display your code in here you need to wrap it in triple back ticks. On a line by itself type three back ticks. Then on the first line below the three back ticks paste in your code. Then below your code on a new line type three more back ticks. The back tick on my keyboard is in the upper left just above the Tab key and below the Esc key. You may also be able to use Ctrl+e to automatically give you the triple back ticks while you are typing in the this editor and the cursor is on a line by itself. Alternatively, with the cursor on a line by itself, you can use the </> button above the editor to add the triple back ticks.

Sorry about that. Here is my css;

:root {
    --building-color1: #aa80ff;
    --building-color2: #66cc99;
    --building-color3: #cc6699;
    --building-color4: #538cc6;
    --window-color1: #bb99ff;
    --window-color2: #8cd9b3;
    --window-color3: #d98cb3;
    --window-color4: #8cb3d9;
}

* {
    box-sizing: border-box;
}

body {
    height: 100vh;
    margin: 0;
    overflow: hidden;
}

.background-buildings, .foreground-buildings {
    width: 100%;
    height: 100%;
    display: flex;
    align-items: flex-end;
    justify-content: space-evenly;
    position: absolute;
    top: 0;
}

/*BACKGROUND BUILDINGS - "bb" stands for "background building"*/

.building-wrap {
    display: flex;
    flex-direction: column;
    align-items: center;
}

.window-wrap {
    display: flex;
    align-items: center;
    justify-content: space-evenly;
}

.sky {
    background: radial-gradient(circle closest-corner at 15% 15%, #ffcf33 0%, #ffcf33 20%, #ffff66 21%, #bbeeff 100%);
}

.bb1 {
    width: 10%;
    height: 70%;
}

.bb1-window {
    height: 10%;
    background: linear-gradient(var(--building-color1), var(--window-color1));
}

.bb1a {
    width: 70%;
}

.bb1b {
    width: 80%;
}

.bb1c {
    width: 90%;
}

.bb1d {
    width: 100%;
    height: 70%;
    background: linear-gradient(var(--building-color1) 50%, var(--window-color1));
}

.bb2 {
    width: 10%;
    height: 50%;
}

.bb2a {
    border-bottom: 5vh solid var(--building-color2);
    border-left: 5vw solid transparent;
    border-right: 5vw solid transparent;
}

.bb2b {
    width: 100%;
    height: 100%;
    background: repeating-linear-gradient(var(--building-color2) 0%, var(--building-color2) 6%, var(--window-color2) 6%, var(--window-color2) 9%);
}

.bb3 {
    width: 10%;
    height: 55%;
    background: repeating-linear-gradient(90deg, var(--building-color3), var(--building-color3), var(--window-color3) 15%);
}

.bb4 {
    width: 11%;
    height: 58%;
}

.bb4a {
    width: 3%;
    height: 10%;
    background-color: var(--building-color4);
}

.bb4b {
    width: 80%;
    height: 5%;
    background-color: var(--building-color4);
}

.bb4c {
    width: 100%;
    height: 85%;
    background-color: var(--building-color4);
}

.bb4-window {
    width: 18%;
    height: 90%;
    background-color: var(--window-color4);
}

/*FOREGROUND BUILDINGS - "fb" stands for "foreground building"*/

.fb1 {
    width: 10%;
    height: 60%;
}

.fb1a {
    border-bottom: 7vh solid var(--building-color4);
    border-left: 2vw solid transparent;
    border-right: 2vw solid transparent;
}

.fb1b {
    width: 60%;
    height: 10%;
    background-color: var(--building-color4);
}

.fb1c {
    width: 100%;
    height: 80%;
    background: repeating-linear-gradient(90deg, var(--building-color4), var(--building-color4) 10%, transparent 10%, transparent 15%), repeating-linear-gradient(var(--building-color4), var(--building-color4) 10%, var(--window-color4) 10%, var(--window-color4) 90%);
}

.fb2 {
    width: 10%;
    height: 40%;
}

.fb2a {
    width: 100%;
    border-bottom: 10vh solid var(--building-color3);
    border-left: 1vw solid transparent;
    border-right: 1vw solid transparent;
}

.fb2b {
    width: 100%;
    height: 75%;
    background-color: var(--building-color3);
}

.fb2-window {
    width: 22%;
    height: 100%;
    background-color: var(--window-color3);
}

.fb3 {
    width: 10%;
    height: 35%;
}

.fb3a {
    width: 80%;
    height: 15%;
    background-color: var(--building-color1);
}

.fb3b {
    width: 100%;
    height: 35%;
    background-color: var(--building-color1);
}

.fb3-window {
    width: 25%;
    height: 80%;
    background-color: var(--window-color1);
}

.fb4 {
    position: relative;
    left: 10%;
    width: 8%;
    height: 45%;
}

.fb4a {
    border-top: 5vh solid transparent;
    border-left: 8vw solid var(--building-color1);
}

.fb4b {
    display: flex;
    flex-wrap: wrap;
    width: 100%;
    height: 89%;
    background-color: var(--building-color1);
}

.fb4-window {
    width: 30%;
    height: 10%;
    border-radius: 50%;
    background-color: var(--window-color1);
    margin: 10%;
}

.fb5 {
    position: relative;
    right: 10%;
    width: 10%;
    height: 33%;
    background: repeating-linear-gradient(var(--building-color2), var(--building-color2) 5%, transparent 5%, transparent 10%), repeating-linear-gradient(90deg, var(--building-color2), var(--building-color2) 12%, var(--window-color2) 12%, var(--window-color2) 44%);
}

.fb6 {
    width: 9%;
    height: 38%;
    background: repeating-linear-gradient(90deg, var(--building-color3), var(--building-color3) 10%, transparent 10%, transparent 30%), repeating-linear-gradient(var(--building-color3), var(--building-color3) 10%, var(--window-color3) 10%, var(--window-color3) 30%);
}

@media (max-width: 1000px) {
    .sky {
        background: radial-gradient(circle closest-corner at 15% 15%, #ccc 0%, #ccc 20%, #445 21%, #223 100%);
    }
}

Hmm, I’m not sure why this isn’t passing for you. I copy/pasted exactly what you have above into the step and it passed for me. Seems strange that you were able to pass the previous step but not this one when all you did is change the color values. Something is not adding up here.

I’m testing with FF on linux, so perhaps there is something strange going on with your particular browser/OS combination? I just can’t figure what that would be. Maybe try a different browser?

1 Like

On the plus side, while I was testing this I just triggered the bug that caused the instructions and buttons to not display in the editor. I’m not sure what I did to trigger it, but maybe I’ll be able to find some potential causes :crossed_fingers:

1 Like

I am on a pc using a Chrome browser. I’ll try Firefox. Thanks.

1 Like

I just tried it and found the problem. I didn’t notice that the first line of the media query was already in the code above the box where the answer is entered. So I had;

@media (max-width: 1000px) {
@media (max-width: 1000px) {
    .sky {
        background: radial-gradient(circle closest-corner at 15% 15%, #ccc 0%, #ccc 20%, #445 21%, #223 100%);
    }
}

That’s why it didn’t work.
Thanks for your help.

1 Like

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.