Learn Regular Expressions by Building a Password Generator - Step 24

Tell us what’s happening:

Hi all,

I thought I did this while True: loop correct. What am I missing from this? is it indentation? Any ideas? Tried looking on other posts but cannot figure it out.

Your code so far

import secrets
import string


def generate_password(length, nums, special_chars, uppercase, lowercase):
    # Define the possible characters for the password
    letters = string.ascii_letters
    digits = string.digits
    symbols = string.punctuation

    # Combine all characters
    all_characters = letters + digits + symbols

# User Editable Region

while True:
    password = ''
    # Generate password
    for _ in range(length):
        password += secrets.choice(all_characters)

# User Editable Region

    return password

# new_password = generate_password(8)
# print(new_password)

Your browser information:

User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36

Challenge Information:

Learn Regular Expressions by Building a Password Generator - Step 24

Welcome to our community!

The ‘while’ loop belongs to the function. Your indentation is not correct for it.

Thank you so much!

I was totally missing the indentation. I wish this was a bit more clear. I am just beginning with python so it would be nice to have a bit more of an explanation in lessons as opposed to just erroring out.

    while True:
        password = ''
        # Generate password
        for _ in range(length):
            password += secrets.choice(all_characters)

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.