Learn Regular Expressions by Building a Password Generator - Step 61

please correct my coding

import re
import secrets
import string


def generate_password(length, nums, special_chars, uppercase, lowercase):
    # Define the possible characters for the password
    letters = string.ascii_letters
    digits = string.digits
    symbols = string.punctuation

    # Combine all characters
    all_characters = letters + digits + symbols

    while True:
        password = ''
        # Generate password
        for _ in range(length):
            password += secrets.choice(all_characters)

        constraints = [
            (nums, r'\d'),
            (lowercase, r'[a-z]'),
            (uppercase, r'[A-Z]'),
            (special_chars, fr'[{symbols}]')
        ]


# User Editable Region

        # Check constraints
        count = 0
        if (constraint <= len(re.findall(pattern, password)) for constraint, pattern in constraints):
            break          

# User Editable Region

    return password

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36

Challenge Information:

Learn Regular Expressions by Building a Password Generator - Step 61

Hi @revanajustin

Please move the for statement onto a new line.

The instructions asked you to use list comprehension syntax.

Happy coding

if all(constraint <= len(re.findall(pattern, password))
for constraint, pattern in constraints):
break
return password

like this??
but it’s still wrong

The for keyword is part of the list comprehension (there is no need to put it on a new line), but you don’t have any list comprehension here. A list comprehension requires the use of square brackets:

[<code_to_execute> for var_1, var_2 in iterable]

Also, you should not use all() yet.

1 Like