Let's discuss your "Local Weather App"

Really good job on your comments. I was able to understand your code very clearly. I’m about to begin mine so this really gives me a good direction of what to do. Any tips for someone who’s gonna start this project will be appreciated. Good job :thumbsup:

Hey everybody,
I have just completed my simple weather app. Any and all feedback is greatly appreciated!

https://codepen.io/CurtisjCamp/full/KqvxYK/

Thank you

Great work and design.
It’s a little bit not convinient to convert seperately temperature real and feels like temperature from celesium to fahrenheit and back. May be it should converts together when click on one of it. And why you do not want to show other important options of weather like wind speed, it’s direction, probability of precipitation, humidity? Api that you use give you all the data.

Instead of that long part of code

     $("#icon").ready(function() {
                if (icon === "clear-day") {
                  $("#icon").html(icons.set("icon", Skycons.CLEAR_DAY));
                } else if (icon === "clear-night") {
                  $("#icon").html(icons.set("icon", Skycons.CLEAR_NIGHT));
                } else if (icon === "rain") {
                  $("#icon").html(icons.set("icon", Skycons.RAIN));
                } else if (icon === "snow") {
                  $("#icon").html(icons.set("icon", Skycons.SNOW));
                } else if (icon === "sleet") {
                  $("#icon").html(icons.set("icon", Skycons.SLEET));
                } else if (icon === "wind") {
                  $("#icon").html(icons.set("icon", Skycons.WIND));
                } else if (icon === "fog") {
                  $("#icon").html(icons.set("icon", Skycons.FOG));
                } else if (icon === "cloudy") {
                  $("#icon").html(icons.set("icon", Skycons.Cloudy));
                } else if (icon === "partly-cloudy-day") {
                  $("#icon").html(icons.set("icon", Skycons.PARTLY_CLOUDY_DAY));
                } else if (icon === "partly-cloudy-night") {
                  $("#icon").html(icons.set("icon", Skycons.PARTLY_CLOUDY_NIGHT));
                } else {
                  $("#icon").html("Zero");
                }

you may use the short

$("#icon").ready(function() {
    icon = icon.toUpperCase().replace(/-/g, "_");
    icons.set("icon", Skycons[icon]);
    icons.play();
});
2 Likes

Thanks for the help with shortening all of that code, it felt cumbersome when I was writing it.

I think I will work on making a F-C toggle that would be a lot more functional.

I decided to leave out the other parts of the api because I didn’t want the page to look like a big block of data. At that point I also felt like I understood how to pull the JSON through without too many problems.

I may in the future add some tabs or even some options on the navbar for the other weather parameters which could look nice.

Thank you very much for your feedback!

My weather app - https://codepen.io/ghosnakes/full/YQZRYr/

I spent more time styling it than building it lol. Was trying to implement different things like five day forecast and color change based on temp, but just went with something simple.

1 Like

Feedback is appreciated, just curious to know if it works for everyone.

Hi all,
It’s my 3.5week into FreeCodeCamp, excuse my hardcoding, would love to get some comments and advice. Thank you

Project Link - https://codepen.io/SammyCat1024/full/QgOmZg/

Hey, it looks real clean. I especially like the moving sun icon. One functional issue is that when I loaded up the site it showed me Los Angeles’ weather instead of mine, so maybe something funky going on with loading the API and Geolocation. Other than that it looks great.

I finished my local weather app and appreciate getting feedback :D.

@migohunter
I’m from Myanmar and it do not work here :frowning: . And, I think it would be better to show the location with city name instead of latitude and longitude :D. cheer!

1 Like

I really like your design.It’s so cool!
But you use time zone for display my location.
What if I am in the same time zone but in another place. The location will be wrong.
Try it with different coordinates.
This 54.9552, 73.4381
And this 56.8917, 74.4258
It’s very simple to check for different places changed your code in js

`var latitude =  56.8917;//position.coords.latitude;` 
`var longitude = 74.4258;//position.coords.longitude;`

Does the weather not show up for you or is it just inaccurate? Thank you for your feedback ^^

Project Link - https://codepen.io/aloeandnatural/full/OgQNqa/1

Feedback is appreciated.

Thanks for your feedback.
I think the geolocation is working on chrome computer but not in the mobile version (android).

Fix :
1 Enable location services in android devices
or
2. Use an IP-API for location.

Thank you… I failed to to think in that way…

sorry my bad… it took some times to show up and I thought it’s not working.

1 Like

Hi all. I just finished up my Local Weather App. I’d love to hear your feedback/advice/critique on this project. Thank you :smiley:

Here is the link - Local Weather App

2 Likes

It shows my location wrong. I am in Omsk, it says I am in Irkutsk. There are more than 1000 km between these cities. May be should use navigator that we studied in lessons fcc

Hi!
Please, look at my weather app
Is everything correct?(location, weather)

@miraahmad - I reeeeally like your design! Although I have to imagine some parts of it because it only shows me temperature and an icon, no text in other boxes. But it’s beautiful! Nicely chosen colors and layout.

Here’s mine. Relatively proud of it, roast me!

Project Link - https://codepen.io/stuomas/full/apVVxR/