Let's discuss your "Local Weather App"

Code Feedback
718

I used forecast.io/Dark Sky!

https://darksky.net/dev

1 Like
719

Okay thanks ill try it out :slight_smile:

720

What do you think? :slight_smile:

https://codepen.io/JonathanBnn/pen/dZOrXK

Background changes depending on the weather (not what time it is though), and for each background, there is a link to the authorā€™s profile on Unsplash: itā€™s a site with free high-resolution photos, check it out if you donā€™t know it, I highly recommend it!

721

Its functional and correct, but try making the F and C and a with href="#" so it looks clickable when you hover over it.

722

If i copy and paste your api, i get a JSON that has my location and everything. SO must be something wrong with accessing it.

freeCodeCampā€™s weather API offers all of yours + more (weather, weather conditions, etc) so i highly suggest you use it. It worked for me.

723

Thanks for the review :slight_smile: I actually saw this feature on other pens, but I felt that the design makes it obvious.

The arrow indicates that you can toggle between units and that the one greyed out is inactive, donā€™t you think?

Maybe I can just change the icon so that it shows that itā€™s clickable when you hover over it without it being a link.

1 Like
724

It makes it look like more of a button instead of text with the herf.

725

Hey,

Check out my attempt at a weather app https://codepen.io/better-0n/full/XeEaXj
Let me know what you think.

Thanks!

726

Project Link - https://codepen.io/alecaceaes/full/dZXJzO/

727

Hereā€™s my project link guys- https://codepen.io/seyicole/full/EbKBJq/ nothing much -enjoy.

728

image
image1920Ɨ1080 135 KB

Try to Math.floor() your temperature so it fits on the phone screen. Add a background besides white, and try to make the phone bigger.

729

Nice, feel like its a little too spaced out though. Anything you could add to fill it?

730

Thanks John, the phone is an image I donā€™t want it to be blurred out so its the default size of the image, I havenā€™t thought about rounding the temperature because I never saw the result that long in my location. Thanks for reviewing! I might add some background.

1 Like
731

Maybe. Thanks for the feedback.

1 Like
732

My Local Weather App [ https://codepen.io/LyubomirNY/full/zPrEGP/ ] any feedback is appreciated.

1 Like
733

Very nice. Adds some fonts :slight_smile:

I looked over some of your other projects. They look and function really good :smiley:

You can surround your C in a <a href="#> code </a>" to give it that click affect/ makes it look clickable.

734

Hereā€™s my Weather App! I put a lot of time and effort to it! Check that out guys ! :slight_smile:
Project Link - https://codepen.io/dknvmlhok/full/aVwzEE

1 Like
735

@dknvmlhok

Good, but i fell like the background is too transparent. Its also too dark (the temperature background).

Try taking up the whole screen.

otherwise its good :slight_smile:

736

It was a little bit difficult for me - I first studied the example code.
I tested the code on my phone, but nothing shows. I think it is not my codeā€™s problem because the example code also doesnā€™t work on my phone.
If you know the reason why it doesnā€™t work, please tell me! Thank you :slight_smile:

737

@yerim25
Its fine that your temperature goes into decimals but be careful. Sometimes it can output a temperature with 10 decimals after it.

Otherwise it looks good.

You can surround your C in a <a href="#"> html code </a> to give it that click affect/ makes it look clickable

1 Like