Let's discuss your "Random Quote Machine"

Code Feedback
460

Nice project, i like the color choices :+1:

461

Thank you! I appreciated the comment and I am glad you like the project!

462

Project Link - http://s.codepen.io/benjaminadk/debug/aWVobr/GnMnbVVRybOM

Basic simple quote generator. check it out.

463

Project Link - http://codepen.io/caravdv/full/NjvwEr/

464

What is JSONP and CORS, I still donā€™t understand what is it about.
I see for you code you broke the url source in four parts, I donā€™t understand why do you do that, does it work if you use it an a single string?

465

I like it, I like the original topic in the quotes, I like the border style, perfect font selection, itā€™s responsive.

What would I do different?
Resposive font too
Animation to the quote (like @akto suggested)
A different fontawesome icon for ā€œMore adviceā€

Technical questions
I donā€™t understand why you use ā€œjsonpā€ as a third argument in the getJSON line, and why you use the url as a variable and not just paste the url inside the getJSON? Would you explain us that part?

1 Like
466

Thanks so much for your feedback!!!

Yeah, Im going to look into how to make my font responsive and animatedā€¦I just finished the weather app so Im going to give it a try before I move on to the next project.

I think you can sense I was struggling with finding an icon for more advice lol I decided that one would do, but now that you mention it, Ill look around for something else to use instead.

Really good technical question! I have no ideaā€¦horrible answer I know. I was having so many problems with this project and googling to find waysā€¦any wayā€¦to make this work that I must have picked up that method of doing it. I did do it the other way you described in my weather app though, so Im going to go back and see if I can do it that way in this project too. :smile:

1 Like
467

Check out my Quote Machine! Feedback welcome!

2 Likes
468

Itā€™s very good in design, responsiveness and use. Personally Iā€™m against using image as a background, but if you like so, you could try adding dark shadow to the white titles, so they wonā€™t be invisible with light background images.

469

project linkā€“>http://codepen.io/chintuyadav/full/aWVwVJ/
http://codepen.io/chintuyadav/full/aWVwVJ/

470

You have a room for improvement in design and programming. For example

Design
Your colours donā€™t fit together
A white background over any color background is not good
Code
Your buttons should have a pointer cursor
Your tweet button is not working

471

ok iā€™m gonna improve front end design and add some animations and all

Thank you alejojo23

1 Like
473

Project Link: Random Quote Machine

474

Project Link: https://annagalante.github.io/Random-Quote/
Source Code: https://github.com/AnnaGalante/Random-Quote

Iā€™m proud of this one. That twitter functionality gave me quiet the fight!

1 Like
475

I like it, very good and neat design.

476

Thanks for the feedback! Iā€™m glad you like the design. I did notice the lettering was slightly harder to see on some of the images! Thanks for reiterating that, I appreciate the suggestion.

1 Like
477

Project link - https://codepen.io/pinglinh/full/eWzoeG/

Feedback will be greatly appreciated!

1 Like
478

Project link - https://codepen.io/CodeyMcC/pen/Kmmejg

Iā€™m not great with css and the buttons moving when the text box extends annoys me! But i think the functionality is there.

479

Project link - [https://codepen.io/Easy_Rider/pen/YVaWxG] (https://codepen.io/Easy_Rider/pen/YVaWxG)

Feedback will be greatly appreciated!

1 Like
480

That is what I been searching for. If you already completed, plz let me know.
Thank you