Look at my Weather App

Code Feedback
1

Hi there! I’ve just finished my weather app. It is pretty simple.
Please feel free to criticize the code or the design.

Thanks!

1 Like
2

Not bad! I like that you’ve contained your AJAX calls in one function, as opposed to littering the global scope. A couple of things:

  1. go isn’t a very descriptive function name. A name like getAndDisplayWeatherData is long and ugly, but makes the code self-documenting.

  2. The app makes an AJAX call every time the user changes temperature scales! The way you’ve got it set up, it would be really easy to eliminate those extra calls and just use the data you get from the first call.

1 Like
3

I’m going to make those corrections. Thank you very much for your feedback!