Looking for a grade and constructive criticism to my code

Looking for a grade and constructive criticism to my code
0.0 0

#1

Please grade my Random Quote Generator page. :slight_smile: Feedback is welcome too.
https://codepen.io/TonyRednil/pen/jxqRJG


#2

Well, I guess it gets a fail, because you have a syntax error (Unexpected end of input - caused by missing an extra }); in your code which causes your page not to display anything. Indent your code and you will easily see where the issue is.

Also, you have some other errors showing in your browser’s console you need to deal with.

Once you resolve the above issues, I ask why you display the same quote on two different locations of the page (see screenshot below):

Also, you need to take a look at your site on a mobile device, because it does not look so great (see screenshot below).

IPhone 6/7/8

IPad


#3

Thanks for pointing that out. I have been making some changes to this code and I guess I really shouldn’t be changing the one I’m asking for a grade on. I will definitely work on how the site looks in a webpage though.


#4

I have reset it to how it was when I posted it. Would you mind looking at it again? I know it still won’t look great on a mobile.


#5

Try to be consequent in naming your ids and classes. I always prefer to use small case over camel case. Its much easier to remember names of ids or classes you have used in html to pair them correctly in css.


#6

I thought they didn’t work unless they were in camel case. I’ll try that out! Thanks.


#7

It seems to work fine for wide screens.


#8

I’ll work on that. Is your grade still an F?


#9

No, I give it a B now. Work on the responsiveness for smaller screen devices and you will have an A.


#10
You don't need anything inside paragraphs to append html. Also for me better looking placement: #author{ font-size: 25px; color: black; float: right; margin-top: 20px; margin-right: 20px; margin-bottom: 10px; font-weight: bold; }

Lose absolute and percentage. Try like this, see if it helps.