Looking for feedback for the tribute page

Hi! I just finished my first FCC project (the tribute page) and would love to hear what you think of it and where I can improve. All feedback’s appreciated, thank you so much!
Here’s the link: https://codepen.io/codoge/full/XWjeEQd

2 Likes

Hi @codoge!

Welcome to the forum!

I think your page looks good.

A few things.

  • Keep the test suite in the page. You are currently passing 9/10 tests.

  • For codepen, you do not need to include html tags, head tags. There is a section in the html settings to include links for the head.

1 Like

Welcome to the forums @codoge. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to the font goes in the box labeled ‘Stuff for <head>’
    • Unsure if you added it last minute but the head element is no closed correctly. (Though not needed in codepen)
  • Run your HTML code through the W3C validator.
    • There is an HTML coding error you should be aware of and address.
2 Likes

Thanks a lot! I didn’t know that’s how codepen works, it’s really helpful :smiley:

Thank you! I’ve just fixed the things you pointed out. W3C validator looks like a really neat tool.

1 Like

Looks good. My suggestion is we can give some line space between the paragraphs. I like the presentation in ’ FILMOGRAPHY’ section. Good luck :slight_smile:

2 Likes

For some reason the image doesn’t seem to work, so it get replaced by the alt

1 Like

Thanks for the suggestion, I’ve increased it a little bit.

I’m not sure why it’s doing that :confused: The image works on all my devices so I’m wondering if it’s a problem with the source image? Anyway I will see if I can fix it, thanks for pointing it out.

@codoge, I’m seeing all your images with no issues.