Markdown Previewer - Feedback is welcome

[samrosenf]

Hey,

This is my Markdown Previewer.
I saw on someone’s else project feedback a suggestion to add a save button.
I decided to give it a go.

https://codepen.io/samrosenf/full/dyvZVdy

Any feedback is welcome!
Thanks

[jwilkins.oboe]

Hi @samrosenf !

I think your project looks good.

@samrosenf

I saw on someone’s else project feedback a suggestion to add a save button.

I like that feature. Good call.

[bbsmooth]

Overall your project looks very nice. Shout out for adding a custom keyboard focus indicator on not only the Save button but also when the editor is focused.

Speaking of that Save button, it should be an actual <button> instead of an <a>. The general rule is: Links go places, buttons do things.

I think the responsiveness can be improved as well. With the default markdown in the editor, when I narrow my browser window the preview window does move below the editor but the editor is very skinny and takes up only half the available width. If I remove all of the default markdown then the preview window jumps back up to the right of the editor and they are both skinny and take only half the page each.

[samrosenf]

Thanks @bbsmooth for the feedback.
I put the button in a tag because that was the way I learned to implement the save feature.
Is surrounding the <button> in <a> tag in order to create this feature would be better?

Tried to change the look of the page, that’s the new version:
https://codepen.io/samrosenf/full/zYZpRoW

[bbsmooth]

@samrosenf

Is surrounding the <button> in <a> tag in order to create this feature would be better?

Actually, it should just be a <button>. Buttons should not be inside of links and links should not be inside of buttons.