I think mine is better than the given ‘hint’. Especially as it can do the extra checks that are commented out and change default bool value to false in function parameters. just wondering if in the wild the checks would be more vigorous. **Your code so far** **Your browser information:** Us…

You can post solutions that invite discussion (like asking how the solution works, or asking about certain parts of the solution). But please don’t just post your solution for the sake of sharing it. If you post a full passing solution to a challenge and have questions about it, please surround it …

[image] ugwen: if(!node){return false} This part is not quite correct. An empty tree is a valid binary search tree. You should declare the variable bool and give ti a more descriptive name.

i made some changes, but why would i declare the boolean seperately? i like to use function parameters for declaration when working with recursion, although i don’t seem to need to here.

You never declared boolean anywhere, not even as a function argument, so it is automatically created as a global variable. You aren’t using pure recursion but instead modifying a global variable. If this exercise was running in strict mode, that code would error.

function isBinarySearchTree(node, bool=true) ? isn’t that a declaration in function parameter?

[image] JeremyLT: This is still wrong. An empty tree is a valid binary search tree. but… if(node){ this accounts for empties [image] JeremyLT: And there is no reason to forbid additional properties on a node ok, didn’t know. thanks

Ohh, are you checking that every single node was actually created by the Node function above? Why? I’m pretty paranoid, but that sort of logic would go into construction of the tree, not traversal. Both Solution 1 and your code are needlessly complex. Solution 2 is more straightforward. You want i…

no, i was checking every node had those 3 properties, but if they can have others then no need

Mines (not) better - Check if Tree is Binary Search Tree

Curriculum Help

JeremyLT August 5, 2022, 3:00pm 10

Ah, I missed that.

Some people really love smuggling state around in function parameters for recursion, but I don’t care for it. You already have a return value - just use it. Using the return value will simplify your code

This is still wrong. An empty tree is a valid binary search tree.

And there is no reason to forbid additional properties on a node

Topic		Replies	Views
freeCodeCamp Challenge Guide: Check if Tree is Binary Search Tree freeCodeCamp Contributors guide	0	3386	August 3, 2019
freeCodeCamp Challenge Guide: Check if an Element is Present in a Binary Search Tree freeCodeCamp Contributors guide	0	2083	August 3, 2019
Recursive Solution for add a new element to Binary Search Tree freeCodeCamp Contributors contributing	1	659	December 19, 2020
Possible solution to: Use Depth First Search in a Binary Search Tree freeCodeCamp Contributors contributing	0	570	December 20, 2020
Solution Data Structures: Use Depth First Search in a Binary Search TreePassed freeCodeCamp Contributors contributing	1	473	October 12, 2020

Mines (not) better - Check if Tree is Binary Search Tree

Related topics