# "Missile Man Of India" tribute page feedback

**URL:** <https://forum.freecodecamp.org/t/missile-man-of-india-tribute-page-feedback/171229>\
**Category:** I Built This\
**Created:** [January 27, 2018, 4:49pm UTC](https://forum.freecodecamp.org/t/missile-man-of-india-tribute-page-feedback/171229 "2018-01-27T16:49:09Z")\
**Posts on this page:** 5\
**Page:** 1

<div class="post-metadata">

**Author:** ![ShivendraDave](https://avatars.discourse-cdn.com/v4/letter/s/8c91f0/32.png) [@ShivendraDave](https://forum.freecodecamp.org/u/ShivendraDave)\
**Post date:** [January 27, 2018, 4:49pm UTC](https://forum.freecodecamp.org/t/missile-man-of-india-tribute-page-feedback/171229/1 "2018-01-27T16:49:10Z")

</div>

This page is in beta stage,feedbacks are welcome!

See the Pen ["Missile Man Of India" tribute page](https://codepen.io/shivendrarox/pen/eyXRaX/) by Shivendra Singh ([@shivendrarox](https://codepen.io/shivendrarox)) on [CodePen](https://codepen.io).

---

<div class="post-metadata">

**Author:** ![camper](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/camper/32/67027_2.png) [@camper](https://forum.freecodecamp.org/u/camper)\
**Post date:** [January 28, 2018, 4:59am UTC](https://forum.freecodecamp.org/t/missile-man-of-india-tribute-page-feedback/171229/2 "2018-01-28T04:59:34Z")

</div>

@ShivendraDave Great start so far! 🚀 All of the fCC tests are passing. I like that you added FontAwesome icons. 😄 Here are some things to think about for improvement:

- **Strange Doctype** : Here’s what you currently have: `<!DOCTYPE html lang="en">`. For HTML5, the preferred doctype is `<!DOCTYPE html>`. The `lang="en"` part goes below the doctype in the starting HTML tag like this: `<html lang="en">`.

- **Styling IDs** : Currently, you’re selecting the `#img-caption` id in your CSS. I lean on the side of not selecting ids in CSS, so I would recommend against this. Here’s some info [from CSS Wizardry](https://csswizardry.com/2014/07/hacks-for-dealing-with-specificity/) that helps explain why I think it’s not a good idea to select ids in CSS:

- **Main Element** : If you use the main element instead of `<div id="main">`, you can gain an interesting accessibility benefit, as mentioned in the [Jump Straight to the Content Using the main Element](https://beta.freecodecamp.org/en/challenges/applied-accessibility/jump-straight-to-the-content-using-the-main-element) challenge:

Those are the issues I see. This is a good start to the fCC projects. ☀

---

<div class="post-metadata">

**Author:** ![ShivendraDave](https://avatars.discourse-cdn.com/v4/letter/s/8c91f0/32.png) [@ShivendraDave](https://forum.freecodecamp.org/u/ShivendraDave)\
**Post date:** [January 28, 2018, 12:49pm UTC](https://forum.freecodecamp.org/t/missile-man-of-india-tribute-page-feedback/171229/3 "2018-01-28T12:49:04Z")

</div>

so, should i use an in-line style tag,in-spite of using a an id in CSS for targeting a particular element?

---

<div class="post-metadata">

**Author:** ![HaiCia](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/haicia/32/75113_2.png) [@HaiCia](https://forum.freecodecamp.org/u/HaiCia)\
**Post date:** [January 28, 2018, 1:16pm UTC](https://forum.freecodecamp.org/t/missile-man-of-india-tribute-page-feedback/171229/4 "2018-01-28T13:16:38Z")

</div>

Hi @ShivendraDave,

First part above `<hr>` looks gorgeous! and the second part under `<hr>` looks unfinished. No margins, no paddings, no text-aligns, just block of plain text. Play with it it is a lot of fun when You changing one line and whole page looks different.

an answer to your question to camper is use class instead of id or inline styles. You can use tag names but try to use it in more specific way. Look at your img when you put another img to this page you the img will be formatted same as the first img, when you may want to put in in different way. here is a [selectors](https://css-tricks.com/how-css-selectors-work/) explanation.

Good luck. 🙂

---

<div class="post-metadata">

**Author:** ![ILM](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/ilm/32/363239_2.png) [@ILM](https://forum.freecodecamp.org/u/ILM)\
**Post date:** [June 1, 2021, 1:56pm UTC](https://forum.freecodecamp.org/t/missile-man-of-india-tribute-page-feedback/171229/5 "2021-06-01T13:56:08Z")

</div>

Closed on June 1, 2021, 1:56pm UTC


