My Bob Dylan Tribute Page and your informed critique!

Code Feedback
1

https://codepen.io/jordancrowl/pen/gOwGWEW

I’m a big fan of Bobby D. Maybe you are too!

Let me know what you think!

Thanks!

2

Hey Jordan, looks awesome! Love the vibe of the page. My bit of advice would be to contain your #tribute-info a bit more by adding some width and setting your horizontal margins to auto so everything is centered.

#tribute-info {
  width: 40%;
  text-align: center;
  font-size: 18px;
  margin: 30px auto;  
  line-height: 1.5;
}

Thanks for sharing.

1 Like
3

Thanks for your reply good sir. I made some adjustments. Looks tighter. Thank you!

1 Like
4

Your page looks good @jojo4545. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • Mentioning because you have elements misplaced. Everything the browser renders belongs in the body element. You can review this for an understanding of the HTML boilerplate tags.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    • If you want multiple paragraphs then use multiple paragraph elements.
1 Like