My Cristina Yang Tribute Page - Feedback?

Code Feedback
1

Here’s the link to the page, it’s not great and I am very confused but yolo right? anyways criticize me i know there’s something i’m missing, but i’m not sure. mainly looking for that specific part that i don’t have, but if you find any other mistakes, let me know!

1 Like
2

Hi, one bit issue with your page i see is the font colors blend too much with the background, which can make it hard to read. I suggest you use greater contrast.
The responsiveness is also not great, on smaller screen some of the text elements become very narrow.
To complete the test which you fail, you havent put properly your figcaption tag and the text is within it. The id of the figcaption is also not set to the one required- img-caption. Im sure it wont be hard to fix that

3

Welcome to the forums @chloed. Your page looks good. Some things to revisit;

  • Verify your email addr with codepen so we can see your page full view
  • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    • Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “wikipedia entry” is not accessible
  • The contrast on the page makes it hard to read. Light font colors on light background is not a good choice. Search for a contrast checker and see how yours compares.
  • There are a LOT of fonts. Some of which you don’t even link (head element in HTML) or import (CSS). Choose one or two fonts and a default font.
    On a side note, if you place the default font first any font that follows will never be selected.
  • To help with responsiveness it’s better to use relative units rather than hard coding pixel values.

Some general observations. These are suggestions. You do NOT have to incorporate them if you don’t want to.

  • having the tribute info centered makes it hard to read because the lines are different lengths. the eye has a hard time
  • with text centered and bullet points aligned left maybe think about getting rid of the bullet points
4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.