My finished tribute page, please give some feedback!

Code Feedback
1

I just finished the tribute page challenge. My girlfriend (who is a graphical designer) say it’s a mess! What do you think?

(http://codepen.io/dualen/full/dNjVvg/)

2

Hi @dualen,

  • Do not use lower levels to decrease heading font size:
<h1 class="text-center display-3">Master Yoda</h1>
<h2 class="text-center"><em><span id="first-quote">"You must unlearn what you have learned."  </em></span></h2>
     ...
        
<h4 id="last-quote" class="text-center">"May the force be with You."<br><br><img id="mini-yoda" src="http://pre09.deviantart.net/a759/th/pre/i/2016/129/9/b/8_bit_yoda_by_rainbownico-da1uc8a.png">
</h4>

MDN documentation:
<h1>–<h6>: The HTML Section Heading elements - HTML: HyperText Markup Language | MDN

**Do not use lower levels to decrease heading font size: use the CSS font-size property instead.**Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

  • The <q> element:

MDN documentation:
<q>: The Inline Quotation element - HTML: HyperText Markup Language | MDN

The HTML <q> element indicates that the enclosed text is a short inline quotation. This element is intended for short quotations that don’t require paragraph breaks;

HTML inspector:

  • The <br> element cannot be a child of the <ul> element.
 <ul>
       <li>Yoda was born in 896 BBY (Before the Battle of Yavin) and died in 4 ABY (After the Battle of Yavin). Yoda was 900 years old.
       </li>
       <br>

MDN documentation:
<ul>: The Unordered List element - HTML: HyperText Markup Language | MDN

Permitted content
zero or more <li> elements, which in turn often contain nested <ol> or <ul> elements.

Cheers and happy coding :slight_smile: