My first landing page, I will appreciate any feedback :)

Code Feedback
1

Hi all,

I’m new in the coding world so I will be appreciated for some feedback,

I know that is only a simple project but I still try my best with media queries.

Thanx.

2

clap clap … you id it

here is the another landing page in case you wann try … check this youtube url - Responsive landing page using HTML & CSS from scratch - YouTube

3

It `s nice
I wulth use this to center the form :

form {
  border: 1px solid #0491da;
  width: 25em;
  height: 9.356em;
  margin-left: auto;
  margin-right:auto;
  padding: 1em;
}

thet`s my opinion :grinning:

4

Thanks for your feedback and advice I really apriciate that.

1 Like
5

Your page looks good @Zack_W. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • on a side note, the FCC test suite would not work properly if placed in the head element. Codepen is forgiving which is why it works here.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
  • Change the cursor to a pointer when hovering over the submit button
  • Check that the user has entered a valid email addr. Throw an HTML5 validation error if not.
    You learned to do this when coding the survey form
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on on large and small screens
6

Thank you, Roma I will apply your sugestions straight away. Thanx for your feedback:)

7

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.