My First Project: A Tribute Page

Code Feedback
1

Hi everyone, this is my first fcc project, a tribute page about Elon Musk using CSS Grid.
I would very much appreciate your feedback.
Thank you and happy coding.

1 Like
2

This looks really good. The only problem I see is when you hover over links there is a line going through them which looks like they are being cancelled out.

Great work your first project, keep it up!

1 Like
3

This looks absolutely great,very well done,Can you please explain to me how you managed to use that grey color on the background image, I wanted to do that on one of my projects in order to make the over-text more vivid ,but I wasn’t sure how… Keep up the good work

1 Like
4

It looks wonderful. It had a simple (in a good way) look that just feels crisp and clear and fresh. I do agree that the line going through the links is somewhat distracting, but while it does give the feeling of being cancelled out, it looks good.

1 Like
5

Thank you.
I used the ::before pseudo element like that:

#title::before {
content: “”;
display: block;
position: absolute;
top: 0;
width: 100%;
height: 100vh;
background-color: rgba(0, 0, 0, 0.7);
z-index: 1;
}
I added the z-index so i can put the heading can be on top

I hope that hepls, don’t hesitate to ask if you have more questions.

1 Like
6

I think you’re right , gonna try to change it.
Thank you for your feedback

7

thank you appreciate the feedback.
I will try to change it to be better.