My First Project (Tribute Page for Ataturk)

Hi everyone. Here is my first ever project. I just tried to use all information from curriculum. I would love any feedback or suggestions.

Thank you.
Link: TributePage

Hi @TheCleaner !

Welcome to the forum!

I think your page looks good.

I would review the lesson on giving links meaningful text.

“Visit Wikipedia page” is not that accessible.

You have a couple of small errors in your html and css.

Run your code through the html validator and css codepen analyzer.

Hope that helps!

Thank you for your help. Next one will be better :slightly_smiling_face:

Hi @TheCleaner !
Your page looks good. There are some HTML errors but Jessica already posted that.
For CSS, you might want the base setup in your code

*{
  margin:0;
  padding:0;
}

This will fill out the unnecessary space around your page. Also fill the space below your footer by adding margin-bottom: 0px;.
Other things will come up with time.
Nice work!

Thank you for this tip @mrohanrajput. I didn’t know that. And thanks for your nice comments. It’s good motivation for me.

1 Like

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.