My first project - tribute page for Emily Dickinson

Code Feedback
1

Hello everyone,

This is my first responsive tribute page. Check it out and let me know your thoughts :slight_smile:

live version
https://amitqy.github.io/tribute_page/

with code


some font doesn’t appear clearly on the sandbox, don’t know why
2

You did a good job,but there is just one correction to make:
1.You wrote Intrested instead of Interested.This are small errors that need to be corrected,but from that you did a good job,keep up the good work.

3

Hey thanks, I will look into that

4

Your page looks good @amitqy. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
  • You should learn to use external styling.
  • The page needs to be responsive.
    • The h1 overflows the container on smaller screens
  • Review the lesson about giving meaningful text to links.

Side note, the test script is JavaScript. Ideally, you’d put anything JS right before the closing body tag. This way, if for some reason the JS doesn’t load, or takes a while to load, user’s will see your page load.

1 Like
5

Thanks for the feedback, I will look into everything you said