My first project -Tribute Page

Code Feedback
1

Hello everyone…so I just finished my tribute page and I like to see what you think…It’s not of a real person and I know not everyone it’s a fan of Game of Thrones but it was something I already had on mind…here’s the link: https://codepen.io/shanerob1388/full/byQEOb

2 Likes
2

Hello @shanerob1388 and welcome to the community!

Most of my projects are based on things I really like so I think is great you based the tribute page on GoT (I based mine on Nintendo haha). I think it is very well done, the only things I think are not okay are the color of the texts. Grey on red is not so easy to read, and in the end the anchor of wikipedia is really hard to read (blue on black), you should change those colors for visually impaired people.

Your first project was really good and I hope you continue! Good luck!

2 Likes
3

Hi…thanks for the advise I will see what I can do about the colors.

1 Like
4

Nicely done! Loving that you used GoT (kinda crossed my fingers for Arya when I read your post though haha). I really liked the look of your page!

I noticed some minor issues in your HTML with your image of Dany. You seem to have a stray quotation mark, so it marks a bunch of tags as strings instead of code. I’m also pretty sure there isn’t an attribute called “atr” for images, perhaps you meant “alt”?
If you want, you could also add a little nav bar for quick and easy access to all the different h2’s.
Lastly, try pasting this snippet into your HTML, then you’ll get the FCC test cases thing:
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
When I used it I noticed that there’s one User Story you unfortunately don’t pass yet:

The <img> element should responsively resize, relative to the width of its parent element, without exceeding its original size.

Check out the max-width style property!

All in all, great work and welcome to the community!

3 Likes
5

Very cool Tribute Page! Maybe add some kind of links to the different sections!! (navbar etc.) Keep coding!!! :vulcan_salute:

1 Like
6

Looks cool :+1:
Image/Video are slightly bigger in Mobile but rest is perfect

1 Like
7

Nice work! I like the colors and background you used on your page. :+1:

1 Like
8

@shanerob1388, couple of things;

  • your page passes 9/10 user stories. It’s not responsive.
  • codepen provides you with validators for HTML, CSS and JS. Click on the arrow in the upper right and then click on the respective ‘Analyze’ link. There are some things in HTML you can clean up
2 Likes
9

Thanks for telling me…I’ll look at it