My first tribute page - Jobs

Code Feedback
1

Hi!

I finish my first project. I decided to use flexbox and make it responsive. I try to make it as minimalist as possible.
Can you see it here!

Regards! :smile:

2

@gasgen

Project is very impressive. But, a few changes can make it better than ever.

  1. Consider changing text style or font for your sub heading ā€œtroublemakerā€. It will make it distincly visible on page.
  2. Also increase padding for both headings.

Rest of the page seems fine to me. Good job.

3

@Manav_PNH_Infy, Thanks for suggestions!

I change the font of the sub heading as you suggested and also the font of the main content (increase font size and line-height) because reading it again I realized that the previous font generated fatigue at the reading time, now is more friendlyā€¦I thinkā€¦

Thanks again!

4

Nice looking page, but the single paragraph is a serious Wall Of Text and becomes quite difficult to read. Consider breaking it up into multiple paragraphs.

Also, Iā€™m not sure why youā€™re using JS to change the font size of the h1 element. Why not just put it in CSS?

5

Hi @chuckadams!

Youā€™re right i had not noticed about the wall of text :sweat_smile:. I use a <br> for divide the paragraph. I tried dividing with <p> labeles and then adding a bottom-margin but it doesnā€™t work.
Thanks for the tip!

About the JS in the h1 elementā€¦I didnā€™t put any JavaScriptā€¦Can someone have placed it editing my code?

6

Looks much better now with the paragraph breaks.

As for the JS edit, Iā€™m not really sure about how it would have gotten in there. I didnā€™t think codepen allowed arbitrary edits by random users with the share link, and thought theyā€™d have to fork it. I rarely ever use codepen though, so Iā€™m not 100% familiar with its permissions model.

7

Hi @chuckadams,

thatā€™s a nice minimalistic page. Just the gray box looks a bit cramped with text. A bit more padding would give the text inside more space to breathe.

Otherwise good job. Keep it up :slight_smile:

8

Hi @silberfuchs26,

That was the idea, design a minimalistic page :smile:.
Iā€™m going to put a little more of padding in the quote to see what happen!

Thanks for the feedback!