My first website(for the tribute page challenge)

My first website(for the tribute page challenge)
0.0 0

#1

Here is my first webpage ever, been codding about 2 weeks

https://codepen.io/Ph3on1x/pen/wePYjZ


#2

It looks pretty good. I would just point out a few things:

In your css, #photoo is misspelled.

In codepen, they take care of everything outside the , so all of this…

<!DOCTYPE html>
<html lang="">

<head>

    <link rel="stylesheet" href="stylesheet.css">

    <!-- Latest compiled and minified JavaScript -->
    <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js" integrity="sha384-Tc5IQib027qvyjSMfHjOMaLkfuWVxZxUPnCJA7l2mCWNIpG9mGCD8wGNIcPD7Txa" crossorigin="anonymous"></script>

    <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous">
    <title>Tribute</title>

</head>

… is unnecessary. The link and script are actually doing something, but codepen would prefer you to have them do it - you can tell it what you want loaded with their settings/css/add-external-css and settings/js/add-external-js. (And both have a quick add for common files.) What you did here is what you would need to do in most web page coding situations, but is not really “codepen way”. Is it bad? Probably not. I’m just letting you know. (And it is very easy to convert a code pen to the “correct” way to set up a web page - the export button at the bottom right will give you a zip file that nicely sets up your files and directories.)

Just in terms of editing, in the Funakoshi’s (Shotokan) Principals section, you have your list twice. And in each list, Do not think that Karate is only in the dojo. shows up twice. (Maybe it’s a “The first rule of fight club …” kind of thing. :wink: )

Lastly, and maybe this is a personal thing, I don’t like to have such long lines of text - especially on a large screen that can be hard for the eye to follow. I might either increase the font size of narrow that pane to make it more manageable.

But good job.


#3

Thank you for the input appreciate it, i didnt notice the list thing there was actually just a copy and past it had to have other content and i never put it in :rofl: I also dont like the the long lines of text but im not but i dont know how to fully break it up yet :relaxed: im watching and reading alot of bootstrap info so hopefully soon will be able to fix that, i had all the links in the code because i find it difficult to code in codepen so i copied it out of notepad ++ and straight into the online platform :joy:i will fix the list as soon as i get a chance:grin: once again thank you for the kind words and help :grinning:


#4

I would also comment on

            <h1 style="font-weight:700">Shotokan Karate</h1>

That should probably be handled in your css pane.