My Portfolio Project D_Mills

Code Feedback
1

Hi Guys
I just finished my portfolio project after a solid 2 days to complete the first section of the curriculum. If you have any tips to improve it or make it more optimal please let me know. I’m proud of this though so be nice! :stuck_out_tongue:
Thanks

https://codepen.io/D_Mills/full/pojvRzO

Updated version (Thanks @Roma): https://codepen.io/D_Mills/pen/abvvzgy

2

Your portfolio looks good @D_Mills. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • Your page passes 8/12 user stories. (As an aside, your other projects don’t meet all the user stories and noticed that Tech Doc is not responsive)
    • The test script should be included, with all tests passing, when you submit your project.
  • When using codepen it only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to your font would go in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator. Just copy your HTML and paste it into the ‘Validate by Direct Input’ tab.
    • If you take away the html elements since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are errors in your code that you need to clean up.
  • There is no html tag <p1>
  • Do not use the <br> tag to force line breaks or spacing. Use margin and/or padding in CSS
1 Like
3

Hi @Roma
Thanks for the feedback. I’m just trying to decipher through it. :slight_smile:

I don’t really understand what forking is. Am I just essentially creating a copy of the example provided?

When I submitted my pages all the user stories passed so I’m confused as to which stories I still need to achieve. Is there a way to find that out? I thought I got them all.

Should I paste the test script into the ‘Stuff for <head>’ section as well?

I think I understand everything else. I just took a quick look at that W3C validator and it looks brilliant!!

Thanks a lot again I genuinely appreciate you taking your time to help me. Hopefully if you look again in future I will have it all cleared up as well as the older projects too. :stuck_out_tongue:

4

It’s not copying the sample project, what it does is create a new, blank one with just the test script.
You can copy that script and put it into the HTML section of codepen. And as mentioned, keep it there when submitting your projects.

Paste the test script into each of your projects and run it. Did you try it with this one?

  • when a test fails the button will be red. You can click on the red button to see which test failed and an explanation that will help you to correct it.

No. It’s JavaScript. It doesn’t belong in the head element. Ideally, you would but it before the closing body tag but in codepen you can place it at the beginning or end of the HTML section.

Good deal. If you have any questions there’s always the forums.

Happy coding!

1 Like