My Product landing page FCC

Code Feedback
1

I’ve come this far :slight_smile:

https://codepen.io/raulsanctes/full/bGgxdPr

2

Your page looks good @raulsanctes. Some things to revisit;

  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s). (fix that typo, then revisit the issue it causes)
    • (The one for HTML misses things which is why I recommend W3C)
  • Check that the user has entered a valid email addr. Throw an HTML5 validation error if not.
    • You learned to do this when coding the survey form
  • While the hover effect for the submit button looks good on smaller screens, it doesn’t present well on a desktop. This is something you should look into since smaller screen devices don’t have anything that allows the user to hover whereas a desktop will allow hovering.
  • flexbox items seem crowded when viewed on desktop, almost looks like they slightly overlap
1 Like
3

You have always helped me in everything, thank you very much, I still make rookie mistakes, I get carried away by the emotion of having finished (or believe that I have finished) and I publish it. I am taking note of every recommendation you make to me. I think I have managed to solve all the problems you mentioned :slight_smile:
https://codepen.io/raulsanctes/full/bGgxdPr

4

Looks good @raulsanctes.

We all make mistakes. It’s perfectly normal. In the real world, before code gets published it goes through a peer review and then testing to ensure that there are no issues.

1 Like
5

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.