My survey form project~ thank you!

click here to my project

hello everyone here is my second fCC project
i think there are roomsss for improvement
feedback is need please! many many many thanks!!

Hi @xavier.yeung !

I think your form looks good.

I would add the cursor pointer to the submit button.

{cursor: pointer;}
1 Like

Cool ! Looks good :+1:
Suggestion: You can add a pseudo selector hover for your button .
All the best :grin:

1 Like

Your page looks good @xavier.yeung. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • User’s should not have to delete text in the text area in order to put in their comments.
  • Change the cursor to a pointer when hovering over the submit button. (Someone’s given the answer but if you haven’t seen it be sure to search first)
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • There’s an easier way to write this margin: 0.25rem 5rem 0.25rem 5rem;
  • Placeholder text should show the format the user is to enter. It should not be a repeat of the label.
1 Like

is it better to use the “span tag + display: block” to create line break than the

p {
    white-space: pre-line;
  }

???
Thank you!

Instead of using <br> elements to have each inline element on a new line, use or set container elements to be block-level elements so they’ll each take up the full width.

1 Like

Thank you! I will use less inline element in the future!

That’s hard to do when coding a form :slightly_smiling_face: