My tribute page. Any feedback is wellcome =)

My tribute page. Any feedback is wellcome =)
0

#1

Hi everyone
This is my tribute page, I would appreciate any feedback! Thanks.

Project Link - https://codepen.io/JoSaGuDu/full/vWeOxP


#2

Very nice indeed.

(Just a minor issue, there is some horizontal overflow you need to fix)


#3

Hi mubaidr.
Thanks for taking the time and feedback my project! I fixed the overflow problem.
Thanks again!


#4

Hi @JoSaGuDu,

HTML:

  • The cite attribute it must be a valid URL:
<blockquote class="col-12  text-justify quote" cite="Jaime Garz&oacute;n">

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote

A URL for the source of the quotation may be given using the cite attribute

Example

<blockquote cite="http://developer.mozilla.org">
  <p>This is a quotation taken from
  the Mozilla Developer Center.</p>
</blockquote
  • Target blank vulnerability
<a href="https://www.britannica.com/biography/Jaime-Garzon" target="_blank">Britannica.com</a>

MDN documentation:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a

Note: When using target, consider adding rel="noopener noreferrer"
to avoid exploitation of the window.opener API.

https://mathiasbynens.github.io/rel-noopener/

TL;DR If window.opener is set, a page can trigger a navigation in the opener regardless of security origin.

https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/

People using target=’_blank’ links usually have no idea about this curious fact:
The page we’re linking to gains partial access to the linking page via the window.opener object.
The newly opened tab can, say, change the window.opener.location to some phishing page. Or execute some JavaScript on the opener-page on your behalf… Users trust the page that is already opened, they won’t get suspicious.

How to fix
Add this to your outgoing links.

rel="noopener"

Update: FF does not support “noopener” so add this.

rel="noopener noreferrer"

Remember, that every time you open a new window via window.open(); you’re also “vulnerable” to this, so always reset the “opener” property

var newWnd = window.open();
newWnd.opener = null;

Cheers and happy coding :slight_smile:


#5

Hi @erretres, thank you for the review! I really appreciate it.
I already fixed the links rel attribute but for the quote, I am quoting an interview video from youtube. Should I put the video’s link as cite attribute?

Thanks again, you gave me very important information! :+1:t4:


#6

You are welcome :smiley:

yes, I think you can do it:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote

Attributes
cite
…This attribute is intended to point to information explaining the context or the reference for the quote.

Cheers and happy coding :slight_smile:


#7

Awesome! thanks again!