My tribute page (Feedback appreciated)

Code Feedback
1

Hi there, my first project so any feedback is really appreciated.
Seán Kelly

2

Welcome to the forums @rev.paul.j.murphy. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your project.
  • On using codepen. codepen only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to your font would go in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator. Just copy your HTML and paste it into the ‘Validate by Direct Input’ tab.
    • Since copy/paste from codepen you can ignore the first warning and first two errors about language, doctype and head.
    • There are errors you need to clean up.
  • Don’t use the <br> element to force line breaks or spacing. Use margins and/or padding in CSS.

On a side note, in looking at your page it looks like you put in break and have two paragraphs but you didn’t code it as such. Make it two paragraphs, it will read better.

3

Thank you very much, should I resubmit my code once it passes all tests?

4

If you just edit the same pen and the link doesn’t change there’s no need to resubmit. It’ll see the latest one.

1 Like