My Tribute Page - Looking for Feedback/

Code Feedback
1

Hi Everyone,

After strong struggle just completed my Tribute page. Please leave some feedback and comments below.

My Tribute Page

Hope you like it.

Thank you.

2

Hi @SandunAAM ,

This code is not correct:

<!DOCTYPE html>
<html>
<head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1">

    <!--Bootstrap CDN-->
    <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous">

    <!--Fontawesome CDN-->
    <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css">

    <!--Animate.CSS CDN -->
    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/animate.css/3.5.2/animate.css">
  • Using Bootstrap With Codepen
  • If you use the CSS tab and JS tab (for css rules and JavaScript) the page is easier to read/review.

HTML inspector:
" is not a valid attribute of the <span> element.

...
<span class="badge"">1994</span>
...
<span class="badge"">1997</span>
...
<span class="badge"">2010</span>
...
 <span class="badge"">2013</span>
...
 <span class="badge"">2015</span>
...
<span class="badge"">2016</span>

Cheers and happy coding :slight_smile:

3

Thanks for the reply. Fixed the problems.

1 Like
4

I think it looks good @SandunAAM. I like the organization.

5

@SandunAAM I think it looks good!

The headings and time line boxes look really good.

I also like how you incorporated your information as well as FCC’s into the page.

I’m not so sure about the jumping text beside the image though.

6

@the-thief, @collinsGTR Thanks for the feedback.

@the-thief. I guess constant animated quote here could be a distraction to a user.

If possibble please look at my portofolio page and leave a feedback.