My Tribute Page - to the greatest spy who ever lived

My Tribute Page - to the greatest spy who ever lived
0

#1

This is the man who invented spying as we know it today. He created British Intelligence AND American Intelligence. He helped build MI5, MI6, the FBI and the CIA. He was the guy who outsmarted Hitler and all his cronies. He is the reason Germany lost WW2. Please welcome… Sir William Stephonson!!!

My Tribute Page - Sir William Stephonson


#2

Hi @TwoFistedJustice,

  • This code is not correct:
 <h1 class="text-primary text-center">Sir William Stephenson</h1>
      <h3 class="text-primary text-center  title">The Man Who Defeated Hitler</h3>

MDN documentation:

Do not use lower levels to decrease heading font size: use the CSS font-size property instead.
Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.


  • This seems strange:
 <span class="col-sm-3 col-sm-offset-1">

If you look the examples in bootstrap, the cols are attributes of the div:

http://getbootstrap.com/css/#grid-intro

<div class="row">
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
  <div class="col-md-1">.col-md-1</div>
</div>

Cheers and happy coding :slight_smile:


#3

Well sure. But if I’m going to start resizing headers in CSS then I might as well just start with Reset and do it properly. But that’s a whole other level of complicated that I don’t want to get into right now.

As for div vs span: as you can see the column works for both. It doesn’t have to be limited to one or the other.