My tribute to Steve Paul Jobs

Code Feedback
1

Check out my tribute page to steve jobs

2

Nice work keep it up

3

thanks for your review

4

welcome oluwashola1100

1 Like
5

Hi @oluwashola1100,

  • Do not use lower levels to decrease heading font size:
 <h2>Tribute to steve Jobs</h2>

MDN documentation:
<h1>–<h6>: The HTML Section Heading elements - HTML: HyperText Markup Language | MDN

Do not use lower levels to decrease heading font size: use the CSS font-size property instead.Avoid skipping heading levels: always start from <h1>, next use <h2> and so on.

HTML Standard

h2–h6 elements must not be used to markup subheadings, subtitles, alternative titles and taglines unless intended to be the heading for a new section or subsection. Instead use the markup patterns in the §4.13 Common idioms without dedicated elements section of the specification.

Common Idioms
HTML Standard

----

Is better not use the style attribute:

<h4><i style="color:silver" class="fa fa-apple"></i>Tribute Page</h4>

Because, you have multiple styles sources (That’s make the page more difficult to review.):

  • The CSS tab
  • Every element on the html with the style attribute

MDN documentation:
style - HTML: HyperText Markup Language | MDN

The style global attribute contains CSS styling declarations to be applied to the element. Note that it is recommended for styles to be defined in a separate file or files. This attribute and the <style> element have mainly the purpose of allowing for quick styling, for example for testing purposes.

---
  • This code is not correct:
<nav>
 <h2>Steve Paul Jobs</h2>
   <ul>
     <li>
       <h4>Born</h4>
  <p> February 24, 1955 San Francisco, California, U.S.</p>
...
</nav>

MDN documentation:
<nav>: The Navigation Section element - HTML: HyperText Markup Language | MDN

The HTML <nav> element represents a section of a page whose purpose is to provide navigation links, either within the current document or to other documents. Common examples of navigation sections are menus, tables of contents, and indexes.

Cheers and happy coding :slight_smile:

1 Like
6

Good job. I like it.
If you want to direct users to another tab in order to check a link you can add the target attribute set to blank.

Wikipedia

7

Thanks for the advice.

1 Like