My very first tribute page Project (Newbie alert)

Code Feedback
1

So I try to finish this one-page tribute project, while I know it’s imperfect, maybe you could give me some advice or feedback? I will be very happy for that.

Note: I made it relatively simple, but since I also try to open the page in the phone, I think it’s pretty much responsive. I focused on the simple, elegant but readable page to the reader.

https://codepen.io/teguhxsetiawan/full/GaoppO

2 Likes
2

I like it. its simple, informative and the page is fairly responsive. There are a few problems with a code, nothing that cant be fixed.

  • in line 7 your alt tag is missing an ‘=’ in front of it
  • while not mandatory it is always good practice to have valid tags like ‘li’ as children of ul tags so instead of

<ul>
<h3 id=“headline”>A Brief Journey of Kurt’s Life:
<li>1967 – Born in Aberdeen, Washington, USA
</ul>

you should have

<h3 id=“headline”>A Brief Journey of Kurt’s Life:
<ul>
<li>1967 – Born in Aberdeen, Washington, USA
</ul>

this is becase h3 is not a valid child element of ul. This also applies to line 31 where you have a br tag inside your ul tag. its better to bring the br tag outside of the ul tag.
this is a very good attempt, keep up the good work and take care :+1:

3 Likes
3

Thank’s for your feedback! I’ve fixed some mistakes you’ve pointed out.

  • Added ‘=’ after the ‘alt’ tag.
  • Changed the ‘h3’ position before the ‘ul’ tag
  • Added ‘padding’ properties on CSS, instead of using ‘br’ tag
1 Like
4

Its a nice job, but I have a little problem with your UI/UX. They is no need giving distinct colors for each paragraph of your tribute information… Giving it only white color is nice…thank you

5

Thank you for your feedback, I made some changes now, and the UI look a little bit better I think.