Need feedback for FCC projects

Code Feedback
1

Hi, everyone! This is my first attempt for tribute and Technical documentation page. Please feel free to give some suggestions for improvement.
Tribute page: https://codepen.io/safna123/pen/vYOMNRN
Technical doc:https://codepen.io/safna123/pen/VwvYWXb

3

The problem I have with both of your Projects is your color scheme they both hurt my eyes.Please try reading a bit about colour theory https://www.codeinwp.com/blog/using-color-theory-in-web-design/

2 Likes
4

I agree with Mculo, but that’s nothing a little reading and difference of CSS can’t fix! I think this is great, especially the SQL docs.

5

Thanks for the suggestion and I will try to be more focused on color theory in my next project.
Thanks MculoFish & rstorms

1 Like
6

Your pages look good @safnaabuthalif. Some things to revisit;
tribute page

  • You’re hosting the pic of Castro on your machine. No one else will ever see it.
  • You use the strong tag in your tribute info but it doesn’t show. This is because the font you selected doesn’t have a heavier weight. You could try a different font and select 400 (normal weight) and 700 (bold weight)
  • Review the lesson about giving meaningful text to links.

tech doc

  • Don’t use the <br> tag to force line breaks
    • Nest multi-line <code> snippets in<pre> </pre> tags in HTML to preserve whitespace and line breaks. Or you could do
code { 
  white-space: pre; 
}

in CSS and skip the <pre> tag in HTML.

codepen

  • When using codepen it only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to your font would go in the box labeled ‘Stuff for <head>’
1 Like
7

@Roma Thank you for the suggestion Roma , I will try to do that all on my next project. Can you give me some suggestion for using the image files. I am able to use only the system image since images on outer environment gets removed quickly.

8

Try using DropBox for your images

9

Thank you Mculo , I have signed up for dropbox and will use in my projects.

1 Like