# Need feedback for Tribute Page-Project of absolutely newbie

**URL:** <https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190>\
**Category:** I Built This\
**Created:** [January 17, 2020, 5:30pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190 "2020-01-17T17:30:43Z")\
**Posts on this page:** 9\
**Page:** 1

<div class="post-metadata">

**Author:** ![Kesinee](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/kesinee/32/131753_2.png) [@Kesinee](https://forum.freecodecamp.org/u/Kesinee)\
**Post date:** [January 17, 2020, 5:30pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190/1 "2020-01-17T17:30:43Z")

</div>

Hi! I’m a newbie here. I have finished my tribute page, one problem is about the tribute-link, the a:visited on CSS doesn’t work. I can’t figure out why…If you could help me with that it will be awesome 🙂 and if you see any flaws please address it so I can work on that.

Here is Tribute page.

> **[Tribute Page-completed](https://codepen.io/Kodingpowers/pen/XWJZewM)**
>
> ...

Thanks! and I’d really appreciate any feedback.

---

<div class="post-metadata">

**Author:** ![snowmonkey](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/snowmonkey/32/241579_2.png) [@snowmonkey](https://forum.freecodecamp.org/u/snowmonkey)\
**Post date:** [January 17, 2020, 6:17pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190/2 "2020-01-17T18:17:56Z")

</div>

Page looks good, css is solid, very very nice. Margins are a little wide for my taste, and I have never been a huge fan of black backgrounds, but it’s clean and readable.

One thing that I might suggest, in looking through your code, I notice you use the `figcaption` tag, which is _great_ - it’s semantic HTML, and it makes your code self-documenting. But… that tag is normally placed inside another one (where you used the `div` to wrap them, consider the `figure`:

```auto
<figure id="img-div">
  <img src="..." alt="description of image" />
  <figcaption>This is the caption for that image, encapsulated together.</figcaption>
</figure>

```

It’s sort of like the “group by” thing in design software - you use the `figcaption` to group both the image and its caption into a single unit. Not strictly necessary, but I think you might find it useful.

As I said code looks great! Love that there a minimal divs, and the media queries look solid. Nice!

---

<div class="post-metadata">

**Author:** ![Kesinee](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/kesinee/32/131753_2.png) [@Kesinee](https://forum.freecodecamp.org/u/Kesinee)\
**Post date:** [January 17, 2020, 8:12pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190/3 "2020-01-17T20:12:18Z")

</div>

Thank you so much for taking your time to give me the feedback and advise I will look into that.

---

<div class="post-metadata">

**Author:** ![Trey](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/trey/32/131762_2.png) [@Trey](https://forum.freecodecamp.org/u/Trey)\
**Post date:** [January 17, 2020, 8:32pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190/4 "2020-01-17T20:32:26Z")

</div>

Nice! The :visited seems to be working for me. It could be because you have a color that’s very similar to what the link is to begin with. Maybe try changing it to a different color and see if it works then.

---

<div class="post-metadata">

**Author:** ![Kesinee](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/kesinee/32/131753_2.png) [@Kesinee](https://forum.freecodecamp.org/u/Kesinee)\
**Post date:** [January 17, 2020, 9:09pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190/5 "2020-01-17T21:09:43Z")

</div>

It works for me now…I think I was confused by the the two similar color. LOL  
Thanks for taking a look on my project 🙂

---

<div class="post-metadata">

**Author:** ![k4u5hik](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/k4u5hik/32/131764_2.png) [@k4u5hik](https://forum.freecodecamp.org/u/k4u5hik)\
**Post date:** [January 17, 2020, 9:18pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190/6 "2020-01-17T21:18:55Z")

</div>

Page looks good to me. Code seems good, I am a newbie myself.

If I was to suggest improvement on something perhaps it would be better fonts, colours and positioning of things to make it look better.

---

<div class="post-metadata">

**Author:** ![Roma](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/roma/32/112899_2.png) [@Roma](https://forum.freecodecamp.org/u/Roma)\
**Post date:** [January 17, 2020, 11:27pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190/7 "2020-01-17T23:27:36Z")

</div>

Hi @Kesinee, your page looks good. There are some things you may want to revisit;

- codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
  - In HTML this will show that the `figcaption` element cannot be a child of `<div>`. In CSS you have a missing semicolon

- Work on the responsiveness some more. On a smaller screen, things start to fall apart and not look so well. You can resize your browser to see what I mean.

---

<div class="post-metadata">

**Author:** ![Kesinee](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/kesinee/32/131753_2.png) [@Kesinee](https://forum.freecodecamp.org/u/Kesinee)\
**Post date:** [January 17, 2020, 11:48pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190/8 "2020-01-17T23:48:40Z")

</div>

Thanks for very useful info! I will fix it when I get home on Sunday.

---

<div class="post-metadata">

**Author:** ![ILM](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/ilm/32/363239_2.png) [@ILM](https://forum.freecodecamp.org/u/ILM)\
**Post date:** [June 1, 2021, 1:41pm UTC](https://forum.freecodecamp.org/t/need-feedback-for-tribute-page-project-of-absolutely-newbie/342190/9 "2021-06-01T13:41:41Z")

</div>


