Still working on them but would appreciate some comments and suggestions. thanks in advance.
https://codepen.io/umurerwa/pen/GRKqXXz
They both look amazing!
A suggestion: In the first one (https://codepen.io/umurerwa/pen/GRKqXXz), when making the screen smaller, the “Famous Poems” should be in column.
Good luck!
Both looks amazing!
Just a suggestion: In Survey Form, it would look more readable if you had the font size bigger.
Keep up the good work. Thank you.
Thank you for your comment. Effectively the title is more readable now.
Cheers
Pages look okay @Umurerwa08. Some things to revisit;
tribute page
- Keep the test script when forking the pen (
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
).- Your page passes9/10 user stories.
- The test script should be included, with all tests passing, when you submit your projects.
- When using codepen it only expects the code you’d put within the
<body> </body>
element in HTML. (No need to include the body tags). For anything you want to add to<head>
click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.- The link to your font would go in the box labeled ‘Stuff for <head>’
- Mainly mentioning because you’re using the boilerplate template incorrectly. What you have in
head
elements should be inheader
elements. - Everything you’ve got belongs in
body
elements. You’ve got elements outside thebody
elements that all belong within…except forhead
but as mentioned, that’s used incorrectly.
- Run your HTML code through the W3C validator.
- When your code is setup correctly as mentioned above you can ignore the first warning and first two error messages.
- There is code you need to clean up
- Don’t use the
<br>
tag to force line breaks or spacing. Use margin and/or padding in CSS. - Make your page responsive.
- When you fix the failing test case it will be responsive.
- I’m not seeing your page the way you’ve intended. You have
font-family
assigned a couple of times but you never eitherlink
to orimport
the font ‘Belgrano’.
survey form
- Keep the test script when forking the pen (
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
).- The test script should be included, with all tests passing, when you submit your projects.
- When using codepen it only expects the code you’d put within the
<body> </body>
element in HTML. (No need to include the body tags). For anything you want to add to<head>
click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box. - Run your HTML code through the W3C validator.
- Errors in your code you need to clean up
- Don’t use
<br>
to force line breaks or spacing. Use margin and/or padding in CSS.- As an aside,
<br>
is self closing. This (</br>
) is not a valid tag.
- As an aside,
- Make you button look like a button instead of a bar
@Roma Thanks for the feedback, very insightful.
About the coding, Is it wise to code using the codepen, if not what best framework to use? Another thing, Can I submit a project again? I had already submitted those 2 and now I am wondering what to do. If you help me fix the error on the tribute page I can’t seem to understand where I did wrong. Thanks again