Opinions on my tribute page

Opinions on my tribute page
0

#1

Hello,
I would like feedback on my tribute page:


thanks


#2

Hi @Sadiamalik,

CSS inspector:

  • Unexpected unknown property “font-family-monospace”:

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face/font-family

The font-family CSS descriptor allows authors to specify the font family for the font specified in an @font-face rule.

Syntax

/* <string> values */
font-family: "font family";
font-family: 'another font family';

/* <custom-ident> value */
font-family: examplefont;

HTML:

  • Do not use <br> to increase a gap:
<div class="card">
    <h1>Faysal Qureshi</h1>
    <p class="title">Actor and Host</p>
    <p class="text-muted">Pakistan</p>
  </div>
  </br>

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br

Do not use <br> to increase the gap between lines of text; use the CSS margin property or the <p> element.

Cheers and happy coding :slight_smile:


#3

Any particular reason why not to use <br>?

Thanks for the feedback.


#4

Because a margin is not the same as a line break.

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br

The HTML <br> element produces a line break in text (carriage-return). It is useful for writing a poem or an address, where the division of lines is significant.

https://en.wikipedia.org/wiki/HTML

HTML describes the structure of a web page semantically

https://en.wikipedia.org/wiki/HTML#Semantic_HTML

Semantic HTML is a way of writing HTML that emphasizes the meaning of the encoded information over its presentation (look).

Cheers and happy coding :slight_smile: